Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbedtls: Add an alt implementation of timing #14756

Merged
merged 1 commit into from
Jun 10, 2021
Merged

mbedtls: Add an alt implementation of timing #14756

merged 1 commit into from
Jun 10, 2021

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Jun 9, 2021

Summary of changes

Implement the MBEDTLS_TIMING_ALT interface for Mbed OS. This
implementation is sufficient to run the Mbed TLS benchmarking
application.

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

See attached log from running the benchmark with this Mbed TLS timing implementation. This is usually run by the nightly job.

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 9, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 9, 2021

@Patater, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team June 9, 2021 14:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

We need to retrigger travis (force push should help) as we reconfigured Travis plan to fix building again (I can't restart this build). Or close/open PR for a minute.

@Patater
Copy link
Contributor Author

Patater commented Jun 9, 2021

check-config.h patch raised upstream with Mbed-TLS/mbedtls#4634

@Patater Patater mentioned this pull request Jun 9, 2021
Merged
@Patater
mbedtls: Add an alt implementation of timing
b8781e5 
Implement the MBEDTLS_TIMING_ALT interface for Mbed OS. This
implementation is sufficient to run the Mbed TLS benchmarking
application.
@mergify mergify bot added needs: CI and removed needs: review labels Jun 10, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 10, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7620120 into ARMmbed:master Jun 10, 2021
@mergify mergify bot removed the ready for merge label Jun 10, 2021
@JojoS62
Copy link
Contributor

JojoS62 commented Jun 10, 2021

this commit creates a double timing.o module:

Object file timing.o is not unique! It could be made from: mbed-os/connectivity/mbedtls/source/timing.c mbed-os/connectivity/mbedtls/platform/src/timing.cpp

@JojoS62 JojoS62 mentioned this pull request Jun 10, 2021
Closed
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
component: security release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Patater @ciarmcom @0xc0170 @mbed-ci @JojoS62 @mbedmain